Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: google-recaptcha script URL query params #83

Merged
merged 1 commit into from
Jan 9, 2024
Merged

fix: google-recaptcha script URL query params #83

merged 1 commit into from
Jan 9, 2024

Conversation

Pixelik
Copy link
Contributor

@Pixelik Pixelik commented Jan 9, 2024

closes #82

@Pixelik Pixelik changed the title fix: google-recaptcha script URL structure fix: google-recaptcha script URL query params Jan 9, 2024
Copy link
Member

@sinankeskin sinankeskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @Pixelik Thank you for the contribution.

@sinankeskin sinankeskin merged commit 0a05fa0 into algonauti:master Jan 9, 2024
2 of 3 checks passed
@sinankeskin
Copy link
Member

@safeforge let's publish a new version for this change.

@Pixelik
Copy link
Contributor Author

Pixelik commented Jan 9, 2024

You're welcome! 🙂

@safeforge
Copy link
Member

@sinankeskin, I don't have permission to publish the current package. We should ping @algodave.

@Pixelik
Copy link
Contributor Author

Pixelik commented Jan 11, 2024

It should not have been merged. Only 2 out 10 checks were passing. 🤔

@sinankeskin
Copy link
Member

main branch is ok enough.

image

@algodave
Copy link
Member

@sinankeskin Version 2.1.1 just published to npmjs.com

Thanks @Pixelik 🎉

Heads-up! Default branch changed from master to main

cc @safeforge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Appending same query param twice in components/g-recaptcha.js + unnecessary & at the end
4 participants